add limited analysis options#17332
Conversation
yjbanov
requested review from
ferhatb and
mdebbar
and removed request for
iskakaushik
| width: width, | ||
| lineNumber: lineNumber, | ||
| left: left, | ||
| // TODO(yjbanov): I chose -1 value just to fix the analyzer warning. I don't know if it's the right value to pass. |
There was a problem hiding this comment.
The default is -1. No need for TODO. /cc @mdebbar
mdebbar
left a comment
mdebbar
left a comment
There was a problem hiding this comment.
Thanks for doing this!
I would love to be fixing these issues in the files that I'm touching anyway. Is there a way we could enable the analyzer options locally, but not in cirrus?
| // TODO(yjbanov): I chose -1 value just to fix the analyzer warning. I don't know if it's the right value to pass. | ||
| endIndexWithoutNewlines: -1, |
There was a problem hiding this comment.
Any value is fine here since we don't use it for comparison in tests.
Yes, VSCode and IntelliJ pick up this file automatically, so all the lints will show up in your editor as you type. I cleaned up all code for these particular hints, so they should never come back. |
|
I meant the commented ones. |
|
Yeah, you can uncomment them but not commit the analysis_options.yaml changes. |
|
|
This reverts commit 5389159.
This time I'm starting without Cirrus. Will add Cirrus serpartely from code changes. This reverts commit 6d33ee1.
4 participants
Starting with a minimal set of lints and hints. Will gradually expand this file until it's no longer necessary and we can use the global repository analysis_options.yaml.